[PATCH] D47375: [Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 25 08:38:22 PDT 2018

probinson added a comment.

LGTM with the indicated test tweak, but best if @filcab also takes a look.

Comment at: lib/Driver/ToolChains/PS4CPU.cpp:87
+    CmdArgs.push_back("--dependent-lib=libSceDbgAddressSanitizer_stub_weak.a");
+  }
Don't bother with braces for a one-line `if` body.

Comment at: test/Driver/fsanitize.c:624
+// CHECK-ASAN-PS4: --dependent-lib=libSceDbgAddressSanitizer_stub_weak.a
 // CHECK-ASAN-PS4-NOT: {{(\.(o|bc)"? |-l).*-lSceDbgAddressSanitizer_stub_weak}}
 // CHECK-ASAN-PS4: -lSceDbgAddressSanitizer_stub_weak
Repeat this NOT line before the new check? to preserve the property described in the comment.

  rC Clang


More information about the cfe-commits mailing list