[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 25 06:13:31 PDT 2018

erichkeane added inline comments.

Comment at: lib/Driver/Compilation.cpp:42
+      TranslatedArgs(_TranslatedArgs), ContainsError(ContainsError),
+      KeepTempFiles(D.isSaveTempsEnabled()) {
   // The offloading host toolchain is the default toolchain.
I'd prefer to just look this up from 'TheDriver' when it is needed.  We shouldn't store things we can look up easy enough.  


More information about the cfe-commits mailing list