[PATCH] D47367: [ASTImporter] Add ms compatibility to tests which use the TestBase
Gabor Marton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 25 05:00:33 PDT 2018
martong added a comment.
This patch does not target `testImport` because I am not sure how to handle the options there:
auto RunOptsFrom = getRunOptionsForLanguage(FromLang);
auto RunOptsTo = getRunOptionsForLanguage(ToLang);
for (const auto &FromArgs : RunOptsFrom)
for (const auto &ToArgs : RunOptsTo)
EXPECT_TRUE(testImport(FromCode, FromArgs, ToCode, ToArgs,
I think, it is overkill to test all possible combinations of the options, we should come up with something better here.
Perhaps we could exploit parameterized tests here as well. @a.sidorin, @xazax.hun What is your opinion?
More information about the cfe-commits