[PATCH] D41537: Optionally add code completion results for arrow instead of dot
Ivan Donchevskii via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 24 23:31:38 PDT 2018
yvvan marked 4 inline comments as done.
yvvan added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:4148
+ CompletionSucceded |= DoCompletion(Base, IsArrow, None);
> NIT: maybe swap the two cases to do the non-fixit ones first? It is the most common case, so it should probably go first.
The actual completion should be the last because of the "Completion context". I've put them in this order intentionally. I will add comment about that.
More information about the cfe-commits