[PATCH] D47340: [ClangDiagnostics] Silence warning about fallthrough after PrintFatalError

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 24 11:03:43 PDT 2018


xbolva00 created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.

ClangDiagnosticsEmitter.cpp:1047:57: warning: this statement may fall through [-Wimplicit-fallthrough=]

  Builder.PrintFatalError("Unknown modifier type: " + Modifier);
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~

ClangDiagnosticsEmitter.cpp:1048:5: note: here

  case MT_Select: {
                ^


Repository:
  rC Clang

https://reviews.llvm.org/D47340

Files:
  utils/TableGen/ClangDiagnosticsEmitter.cpp


Index: utils/TableGen/ClangDiagnosticsEmitter.cpp
===================================================================
--- utils/TableGen/ClangDiagnosticsEmitter.cpp
+++ utils/TableGen/ClangDiagnosticsEmitter.cpp
@@ -1045,6 +1045,7 @@
     switch (ModType) {
     case MT_Unknown:
       Builder.PrintFatalError("Unknown modifier type: " + Modifier);
+      break;
     case MT_Select: {
       SelectPiece *Select = New<SelectPiece>(MT_Select);
       do {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47340.148454.patch
Type: text/x-patch
Size: 457 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180524/01eaafe2/attachment.bin>


More information about the cfe-commits mailing list