[PATCH] D47274: [clangd] Serve comments for headers decls from dynamic index only

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 24 06:10:44 PDT 2018

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.

Comment at: clangd/CodeCompletionStrings.h:46
                        const CodeCompleteConsumer::OverloadCandidate &Result,
-                       unsigned ArgIndex);
+                       unsigned ArgIndex, bool NoCommentsFromHeaders = true);
this invites double negation.
Also it doesn't seem like a great default, violates principle of least surprise.

prefer bool CommentsFromHeaders = true, or with no default.
(or even consider an enum)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list