[PATCH] D47223: [clangd] Handle enumerators in named, unscoped enums similarly to scoped enums

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 24 05:50:41 PDT 2018

ilya-biryukov added a comment.

> But I feel it's a bit odd that completion and workspace symbols would be inconsistent.

It does not seem that odd to me. Completion is something that should follow the language rules more closely, i.e. we don't want to deviate from sema completions too much. While workspaceSymbol is a user-facing feature and we probably want users to type as little as possible there.
E.g. not showing `namespace_name::A` in completion seems bad to me, since people are used to referring to the enumerators this way and sema completion gives you those results.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list