[PATCH] D47157: Warning for framework headers using double quote includes

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 23 17:05:02 PDT 2018


Eugene.Zelenko added a comment.

In https://reviews.llvm.org/D47157#1110430, @bruno wrote:

> Hi Eugene,
>
> > You could just not include new warning into -Wall and -Wextra. Those who will want to check #include statements correctness could enable it explicitly.
>
> This is exactly what's happening in the patch, the new warning isn't part of `-Wall` or `-Wextra`, and is marked `DefaultIgnore`, which means that will fire only when `-Wquoted-include-in-framework-header` is passed to the driver. Am I missing something from your explanation?
>
> Thanks,


Thank you for clarification! Sorry, I didn't know TableGen syntax well enough to deduce this from source.


Repository:
  rC Clang

https://reviews.llvm.org/D47157





More information about the cfe-commits mailing list