[PATCH] D45212: Add HIP toolchain

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 23 13:47:09 PDT 2018

yaxunl marked an inline comment as done.
yaxunl added inline comments.

Comment at: lib/Driver/ToolChains/HIP.cpp:44
+  }
+  if (!FoundLibDevice)
+    C.getDriver().Diag(diag::err_drv_no_such_file) << BCName;
tra wrote:
> You don't need FoundLibDevice any more as you will  always return from inside the loop if it is ever true.
will remove when committing. Thanks!


More information about the cfe-commits mailing list