[PATCH] D45212: Add HIP toolchain

[Artem Belevich via Phabricator via cfe-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

One small nit. LGTM otherwise.



================
Comment at: lib/Driver/ToolChains/HIP.cpp:44
+  }
+  if (!FoundLibDevice)
+    C.getDriver().Diag(diag::err_drv_no_such_file) << BCName;
----------------
You don't need FoundLibDevice any more as you will  always return from inside the loop if it is ever true.


https://reviews.llvm.org/D45212