[PATCH] D45212: Add HIP toolchain
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 23 13:42:21 PDT 2018
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
One small nit. LGTM otherwise.
Comment at: lib/Driver/ToolChains/HIP.cpp:44
+ if (!FoundLibDevice)
+ C.getDriver().Diag(diag::err_drv_no_such_file) << BCName;
You don't need FoundLibDevice any more as you will always return from inside the loop if it is ever true.
More information about the cfe-commits