[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

Marc-Andre Laperle via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 23 11:38:24 PDT 2018

malaperle added a comment.

In https://reviews.llvm.org/D47272#1109914, @ilya-biryukov wrote:

> In https://reviews.llvm.org/D47272#1109909, @malaperle wrote:
> > > We do not to rely on symbols from the main file anyway, since any info hat those provide can always be taken from the AST.
> >
> > I'll be adding those soon for workspace symbols... And also for document symbols.
> I can add extra code to build pieces for the AST later. This is not hard to do, but would require rearranging some code a bit more.
>  Will try to send the change tomorrow for review tomorrow. Does that SG?

Sounds good. Doesn't have to be tomorrow :) Just making sure we're not on incompatible paths.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list