[PATCH] D46867: [ASTImporter] Add unit tests for structural equivalence

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 23 10:39:39 PDT 2018


a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.

Hi Gabor,

LGTM, thank you for addressing the comments! Just a minor nit, it's OK to fix it before committing without a separate review.



================
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:67
+  bool testStructuralMatch(std::tuple<NamedDecl *, NamedDecl *> t) {
+    using std::get;
+    return testStructuralMatch(get<0>(t), get<1>(t));
----------------
Not sure we need this using: we can move up the `using` below or just write std::get twice.


Repository:
  rC Clang

https://reviews.llvm.org/D46867





More information about the cfe-commits mailing list