[PATCH] D47182: [X86] Move all Intel defined intrinsic includes into immintrin.h
David Kreitzer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 23 09:04:10 PDT 2018
DavidKreitzer added a comment.
Hi Craig, just one comment on the details. Everything else looks good.
Comment at: lib/Headers/x86intrin.h:47
-#if !defined(_MSC_VER) || __has_feature(modules) || defined(__POPCNT__)
I see that you are removing this popcntintrin.h inclusion without adding it to immintrin.h. Is that because you are relying on the inclusion from smmintrin.h?
If so, won't that cause a problem on Windows with -mpopcnt for targets that don't include smmintrin.h?
More information about the cfe-commits