[PATCH] D47187: [clangd] Skip .inc headers when canonicalizing header #include.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 23 05:07:44 PDT 2018

ioeric added inline comments.

Comment at: clangd/index/SymbolCollector.cpp:209
+  while (true) {
+    if (!Loc.isValid() || SM.isInMainFile(Loc))
+      break;
sammccall wrote:
> (as above, maybe want to include the main file for simplicity/symmetry)
Thanks! As you pointed out offline, we would need main file for correctness as well, as a main file could the exporting header.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list