[PATCH] D44954: [clangd] Add "member" symbols to the index

Marc-Andre Laperle via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 22 13:42:50 PDT 2018

malaperle added a comment.

In https://reviews.llvm.org/D44954#1104497, @malaperle wrote:

> >>> What scopes will non-scoped enum members have?
> >> 
> >> Hmm. I think all of them, since you can refer them like that in code too. Case #1 doesn't work but that was the case before this patch so it can probably be addressed separately. I'll add some tests though!
> > 
> > I would vote for making queries `En::A` and `A` match the enumerator, but **not** `::A`. The reasoning is: yes, you can reference it this way in a C++ file, but `workspaceSymbol` is not a real C++ resolve and I think it should match the outline of the code rather than the actual C++ lookup rules.
> >  E.g. I wouldn't expect it to match symbols from base classes, etc. This should also simplify implementation too.
> I don't have a strong opinion, so I can try this suggestion!

I changed the behavior of non-scoped enums as suggested here: https://reviews.llvm.org/D47223

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list