[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

[Mandeep Singh Grang via Phabricator via cfe-commits]

mgrang added inline comments.


================
Comment at: include/clang/Frontend/Utils.h:369
+          llvm::CreateInfoOutputFile();
+      std::sort(FrontendTimes.begin(), FrontendTimes.end(), SortName);
+      using FTPIterator = typename std::vector<FTimePair>::iterator;
----------------
Please use llvm::sort instead of std::sort. See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements.


================
Comment at: include/clang/Frontend/Utils.h:389
+      }
+      std::sort(FinalTimes.begin(), FinalTimes.end(), ftimeSort2);
+      double TimeThreshold =
----------------
Same here.


https://reviews.llvm.org/D47196