[PATCH] D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 22 02:12:18 PDT 2018

martong added inline comments.

Comment at: lib/AST/ASTImporter.cpp:4305
+    // Add to the DC only if it was an explicit specialization/instantiation.
+    if (D2->getTemplateSpecializationKind() != TSK_ImplicitInstantiation) {
+      LexicalDC->addDeclInternal(D2);
a.sidorin wrote:
> Can we write `if (D2->isExplicitInstantiationOrSpecialization())` instead? How we should treat TSK_Undeclared case?
Yes, this is a good catch! Changed it.

  rC Clang


More information about the cfe-commits mailing list