[PATCH] D46052: GNUstep Objective-C ABI version 2

David Chisnall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 22 01:31:29 PDT 2018

theraven added inline comments.

Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
+        char c = Str[i];
+        if (isalpha(c) || isnumber(c))
+          StringName += c;
Ka-Ka wrote:
> The isnumber() function was added to cctype.h by Apple. I don't think it can be used in llvm.
> According to
> https://stackoverflow.com/questions/39204080/what-is-the-difference-between-isdigit-and-isnumber
Ah, isnumber is from 4.4BSD, I assumed it worked everywhere.  Changing it to isdigit is fine.

  rC Clang


More information about the cfe-commits mailing list