[PATCH] D47157: Warning for framework headers using double quote includes

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 21 15:49:45 PDT 2018

Eugene.Zelenko added a comment.

>>> The warning is off by default.
>> We typically do not add off-by-default warnings because experience has shown the rarely get enabled in practice. Can you explain a bit more about why this one is off by default?
> Right. I believe this is going to be used in practice, the reason I'm adding it involves some user demand for such warning. Such quoted include use in frameworks happen often and we would like a smooth transition to happen here (e.g. do not initially affect -Werror users). If it proves worth it, we can migrate to on by default in the future. It wouldn't be a problem if we have it on by default on open source and disable by default downstream, but I rather be consistent.

You could just not include new warning into -Wall and -Wextra. Those who will want to check #include statements correctness could enable it explicitly.

  rC Clang


More information about the cfe-commits mailing list