[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

George Karpenkov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 21 15:21:57 PDT 2018

george.karpenkov added a comment.

@NoQ I'm really wary of magic numbers.

- We should expose it through an analyzer-config flag. We already do so for the budget.
- We should probably have both positive and negative tests. What scenarios _stop_ working after the threshold is decreased? [point 1 is required to be able to test that]
- Finally, do we understand where the slowdown comes from? If it comes from attempted rearrangements due to https://reviews.llvm.org/rC329780 I think we should roll that back instead.

  rC Clang


More information about the cfe-commits mailing list