[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 21 11:54:42 PDT 2018

aaron.ballman added a comment.

In https://reviews.llvm.org/D44539#1106802, @rjmccall wrote:

> In https://reviews.llvm.org/D44539#1106443, @aaron.ballman wrote:
> > In https://reviews.llvm.org/D44539#1106152, @rjmccall wrote:
> >
> > > This was approved by the Objective-C language group as a default-off warning.
> >
> >
> > We usually do not expose new default-off warnings because experience shows that they rarely ever get enabled by users. If the ObjC group doesn't think this should be on by default, I wonder if it should be included in Clang at all.
> That's a fair question to ask.  In this case, I'm in favor of adding it because we have evidence of there being a substantial set of users who would enable it enthusiastically.

Okay, that works for me. Thank you for verifying.

  rC Clang


More information about the cfe-commits mailing list