[PATCH] D47150: [Clang Tablegen] Add llvm_unreachable() to getModifierName()

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 21 10:21:49 PDT 2018


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: utils/TableGen/ClangDiagnosticsEmitter.cpp:495
   }
+  llvm_unreachable("invalid modifier type");
 }
----------------
Perhaps this should say "unhandled case" or similar?


https://reviews.llvm.org/D47150





More information about the cfe-commits mailing list