[PATCH] D47142: [x86] invpcid intrinsic

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: lib/Headers/intrin.h:196
+ */
 void __cdecl _invpcid(unsigned int, void *);
+#endif
----------------
GBuella wrote:
> GBuella wrote:
> > rnk wrote:
> > > craig.topper wrote:
> > > > @rnk, what's the right thing to do here?
> > > What problems does this redeclaration cause?
> > Now that I think about it, none.
> Also, I think this could be added as TARGET_HEADER_BUILTIN..."intrin.h", ALL_MS_LANGUAGES into BuiltinsX86.def
> And removed from here.
> Right?
It could be, but then you'd need to implement it as a builtin instead of having invpcidintrin.h, right?


Repository:
  rC Clang

https://reviews.llvm.org/D47142