[PATCH] D47142: [x86] invpcid intrinsic
Gabor Buella via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 21 10:08:36 PDT 2018
GBuella added a comment.
In https://reviews.llvm.org/D47142#1106664, @rnk wrote:
> Why do we need a feature flag for this in the first place? The MSVC model for most "instruction" intrinsics is that the exact instruction is emitted regardless of the feature enabled. The target attribute seems like it would get in the way of that.
I'm fine with getting rid of the feature flag, here, and then probably also for other instructions in similar situations (pconfig, wbnoinvd, clwb, etc...).
But as long as we keep those other feature flags, I guess we should just be consistent.
More information about the cfe-commits