[PATCH] D47122: [clang-tidy] SimplifyBoolenExpr doesn't add parens if unary negotiation is of ExprWithCleanups type

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 21 07:46:34 PDT 2018

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, with a small nit.

Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:78
   E = E->IgnoreImpCasts();
+  if (auto *EC = dyn_cast<ExprWithCleanups>(E))
+    E = EC->getSubExpr();
`const auto *`, please.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list