[PATCH] D46910: [Support] Avoid normalization in sys::getDefaultTargetTriple
Nico Weber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 21 04:41:58 PDT 2018
thakis added a comment.
> Sorry about the breakage, I wasn't aware of that test failure and never got any email (probably because the bot has been red before). I'll try to fix make_itanium_abi_triple and test it on my Windows box tomorrow before resubmitting.
Thanks, sounds good. Reading the history of the review a bit, it sounds like Reid did try to test this on Windows. My guess is that he didn't create a completely new build directory, and that cmake's cache made it so that he didn't see all the changes that are in here. (Our bots always blow away the cmake cache on each build for this reason.) So make sure to create a fresh build dir for each local iteration of the patch when you test this.
> The change was made through monorepo and submitted via `git llvm push` which allows changing multiple projects in one commit.
Is there some toggle necessary to make it so that all parts of the patch show up on phab? For this issue, phab only displays the clang bit, which confused me for a while.
More information about the cfe-commits