[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 21 00:52:08 PDT 2018

rjmccall added a comment.

This was approved by the Objective-C language group as a default-off warning.

Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1018
+def warn_objc_property_assign_on_object : Warning<
+  "'assign' attribute must not be of object type, use 'unsafe_unretained' instead">,
+  InGroup<ObjCPropertyAssignOnObjectType>, DefaultIgnore;
"must" is rather strong for a warning.  Maybe something more like "'assign' attribute on property of object type could be 'unsafe_unretained'"?

  rC Clang


More information about the cfe-commits mailing list