[PATCH] D47092: downgrade strong type info names to weak_odr linkage

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 18 16:28:34 PDT 2018


rjmccall added a comment.

In https://reviews.llvm.org/D47092#1105317, @rjmccall wrote:

> Incomplete classes are a curse.  I don't suppose we can just modify the language specification to make it illegal to use `typeid(Incomplete*)`?  Or make equality/hashing undefined in these cases?


Honestly, I'm somewhat inclined to just declare this for Darwin and make us non-conformant.  It's not like this has ever previously worked, and this patch is going to be disruptive for our internal C++ developers by introducing new global weak symbols that they can't get rid of except by disabling RTTI.  (It would always have been a problem if they were actually using RTTI, of course, but one of the whole problems with RTTI is that you live with the consequences whether you use it or not.)


Repository:
  rC Clang

https://reviews.llvm.org/D47092





More information about the cfe-commits mailing list