[PATCH] D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 18 09:21:34 PDT 2018


a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.

Hi Gabor! I have a question.



================
Comment at: lib/AST/ASTImporter.cpp:4305
+    // Add to the DC only if it was an explicit specialization/instantiation.
+    if (D2->getTemplateSpecializationKind() != TSK_ImplicitInstantiation) {
+      LexicalDC->addDeclInternal(D2);
----------------
Can we write `if (D2->isExplicitInstantiationOrSpecialization())` instead? How we should treat TSK_Undeclared case?


Repository:
  rC Clang

https://reviews.llvm.org/D47058





More information about the cfe-commits mailing list