[PATCH] D47068: Move #include manipulation code to new lib/Tooling/Inclusions.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 18 07:19:58 PDT 2018


ioeric marked an inline comment as done.
ioeric added inline comments.


================
Comment at: include/clang/Format/Format.h:20
 #include "clang/Tooling/Core/Replacement.h"
+#include "clang/Tooling/Inclusions/IncludeStyle.h"
 #include "llvm/ADT/ArrayRef.h"
----------------
ilya-biryukov wrote:
> Maybe `Tooling/Includes`?
> I think inclusions is somewhat uncommon, while includes is more widely used. Don't have a strong opinion, though.
I decided to use `Inclusions` over `Includes` or `Headers` because those two can be confused with directories that contain headers for the library.


Repository:
  rC Clang

https://reviews.llvm.org/D47068





More information about the cfe-commits mailing list