[PATCH] D46940: [ASTImporter] make sure that ACtx::getParents still works

Rafael Stahl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 16 07:59:43 PDT 2018


r.stahl added inline comments.


================
Comment at: lib/AST/ASTImporter.cpp:6755
+  auto ToE = cast_or_null<Expr>(Import(cast<Stmt>(FromE)));
+  if (ToE)
+    ToContext.invalidateParents();
----------------
a.sidorin wrote:
> We already do the invalidation in Import(Stmt), so it looks redundant here.
Yes, sorry this should actually be in Import(Decl) as I wrote in the description!


Repository:
  rC Clang

https://reviews.llvm.org/D46940





More information about the cfe-commits mailing list