[PATCH] D46805: If some platforms do not support an attribute, we should exclude the platform

[Li Jia He via Phabricator via cfe-commits]

HLJ2009 marked 4 inline comments as done.
HLJ2009 added inline comments.


================
Comment at: include/clang/Basic/Attr.td:327
+def TargetDarwinNegative : TargetArch<["x86", "x86_64"]> {
+  let OSes = ["MacOSX"];
+  let Negated = 1;
----------------
aaron.ballman wrote:
> I would expect the OS would be named "Darwin" and not "MacOSX" given the name of the target. Which flavor should be used, or should both be used?
hi,Aaron
   First, I set OSType to Darwin,but it does not work on my own machine. so I set OSType to MacOSX,and it is ok.Yes, I thought about adding two at the same time, but this needs to modify list<string> OSes to list<string> OSes[].


Repository:
  rC Clang

https://reviews.llvm.org/D46805