[PATCH] D46522: [clang] cmake: resolve symlinks in ClangConfig.cmake

Sat May 12 01:41:50 PDT 2018

Lekensteyn added a comment.

In https://reviews.llvm.org/D46522#1096847, @kimgr wrote:

> I'm interested in this, I've tried for a while to fix the Debian packaging but I'm completely new to the packaging toolchain, so I'm making slow headway.

The Debian clang-5.0 1:5.0.2-2 package already includes this patch. I tried to upstream it, but there were some concerns about the real path not always being the desired value.

> My (possibly naive) take is that since the LLVM/Clang build/install tree works as-is with `find_package`, the bug must be in packaging. That is, if you have a local build tree in `/build/`, this configures without a hitch: `cmake -DCMAKE_PREFIX_PATH=/build/ -G Ninja .` with a simple `CMakeLists.txt` doing `find_package` for both LLVM and Clang.

On Debian, `cmake -DCMAKE_PREFIX_PATH=/usr/lib/llvm-5.0` would work as well, the problem was that the FindClang.cmake file was installed into an unexpected location (packaging issue).

Secondary to that, some additional symlinks were installed to ensure that users do not have to set `CMAKE_PREFIX_PATH` in order to find some LLVM/Clang version. That scenario was being addressed with this patch (and https://reviews.llvm.org/D46521).

Repository:
  rC Clang

https://reviews.llvm.org/D46522