[PATCH] D43320: Allow dllimport non-type template arguments in C++17

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 10 13:27:45 PDT 2018


rnk added a comment.

Thanks for the guidance!



================
Comment at: clang/lib/AST/ExprConstant.cpp:1871-1902
       if (!CheckConstantExpression(Info, DiagLoc, EltTy,
                                    Value.getArrayInitializedElt(I)))
         return false;
     }
     if (!Value.hasArrayFiller())
       return true;
     return CheckConstantExpression(Info, DiagLoc, EltTy,
----------------
rsmith wrote:
> `Usage`  should be passed into these recursive calls to `CheckConstantExpression`, although that's NFC for now, until/unless we start allowing class types as template parameters.
Makes sense, done.


Repository:
  rC Clang

https://reviews.llvm.org/D43320





More information about the cfe-commits mailing list