[PATCH] D46664: Fix null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel()

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 9 17:36:38 PDT 2018


rnk added a comment.

Is it possible to fix this in assignInheritanceModel instead? I'd imagine we'd get the most recent decl. If that's not the issue, maybe you're fixing the bug in the right spot, but we need to find out where other class template attributes are moved from instantiation to real declaration.



================
Comment at: lib/Sema/SemaTemplate.cpp:7079
 
+void Sema::CheckCXXRecordDecl(CXXRecordDecl *Record, CXXRecordDecl *Prev)
+{
----------------
This seems like an overly-generic name for what it does, which currently is specific to class template instantiations.


Repository:
  rC Clang

https://reviews.llvm.org/D46664





More information about the cfe-commits mailing list