[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 9 10:24:37 PDT 2018


ilya-biryukov added a comment.

In https://reviews.llvm.org/D42966#1085303, @mikhail.ramalho wrote:

> Hi,
>
> > Where do virtual files come from in the first place?
>
> From the linemarker:


I tried dumping locations in presence of line markers.
They have non-null `FileEntry` and a reasonable offset, so the original code should work just fine in presence of line markers.
I don't see why changing to presumed locations fixes the issue with not generating the USRs.

Could you provide a minimal example where USRs are not generated? It might be the case that there are other ways to fix it.


Repository:
  rC Clang

https://reviews.llvm.org/D42966





More information about the cfe-commits mailing list