[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 9 00:18:47 PDT 2018


hans added a comment.

In https://reviews.llvm.org/D46520#1092233, @rnk wrote:

> Please don't do this, this is actually really problematic, since `#line` directives lose information about what's a system header. That means the result of -E usually won't compile, since Windows headers are typically full of warnings and default-error warnings.


Sorry, I didn't realize this was the case :-/


Repository:
  rL LLVM

https://reviews.llvm.org/D46520





More information about the cfe-commits mailing list