[PATCH] D46471: [HIP] Add hip offload kind

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: lib/Driver/Compilation.cpp:201
+  // not compiled again if there are already failures. It is OK to abort the
+  // CUDA pipeline on errors.
+  if (A->isOffloading(Action::OFK_Cuda) || A->isOffloading(Action::OFK_HIP))
----------------
rjmccall wrote:
> Mentioning only CUDA in the second clause makes me wonder whether it's *only* okay to abort a CUDA pipeline, not a HIP one.  That is presumably not your intent.  You could just drop "CUDA" there.
The second sentence is OK for both CUDA and HIP. Will drop CUDA in the second sentence.


https://reviews.llvm.org/D46471