[PATCH] D46472: [HIP] Support offloading by linkscript

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

The IRGen aspects of this seem reasonable, modulo a comment change.  I don't feel qualified to judge the driver change.



================
Comment at: lib/CodeGen/CGCUDANV.cpp:317
+  if (GpuBinaryFileName.empty() && !IsHIP)
     return nullptr;
 
----------------
Is this filename string only used for CUDA?  If so, please rename it to make that clear, or at least add a comment.


https://reviews.llvm.org/D46472