[PATCH] D46439: Fix incorrect packed aligned structure layout

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

This looks fine, but needs a test.



================
Comment at: lib/Sema/SemaDecl.cpp:15576
 
+    // Handle attributes before checking for alignas underalignment.
+    if (Attr)
----------------
More generally: "before checking the layout".


================
Comment at: lib/Sema/SemaDecl.cpp:15651
     }
   } else {
     ObjCIvarDecl **ClsFields =
----------------
Do we need to do any attribute processing in this Objective-C interface / implementation / category case?


Repository:
  rC Clang

https://reviews.llvm.org/D46439