[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

Vedant Kumar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 4 12:27:44 PDT 2018


vsk added inline comments.


================
Comment at: lib/Driver/SanitizerArgs.cpp:118
       BlacklistFiles.push_back(Path.str());
+    else if (BL.Mask == CFI)
+      D.Diag(clang::diag::err_drv_no_such_file) << Path;
----------------
vsk wrote:
> CFI can be enabled with other sanitizers, such as ubsan. I think you'll need 'Mask & CFI' here. It'd be great to have a test for this case, too (i.e -fsanitize=cfi,undefined -resource-dir=/dev/null should also give you this diagnostic).
Sorry, I misread the surrounding code. Your check is fine as-is.


https://reviews.llvm.org/D46403





More information about the cfe-commits mailing list