[PATCH] D43750: Allow writing calling convention attributes on function types

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman closed this revision.
aaron.ballman added a comment.

In https://reviews.llvm.org/D43750#1085780, @rsmith wrote:

> I'm really sad about this; C++11 attributes were supposed to fix the undisciplined "do what I mean" behavior of GNU attributes. But you're right, these really are type attributes, and really should be permitted to appertain to types. That we permit these to appertain to function declarations is the mistake, but it's a mistake we need to make to match GCC, so while I'm sad about it, I think this patch is the right thing.


Yeah, this situation doesn't make me overly happy but I think it's the best way for us to move forward. Hopefully, after enough time has passed, we can consider deprecating writing these attributes on declarations with the eventual goal of disallowing it.

Committed in r331459.


https://reviews.llvm.org/D43750