[PATCH] D46180: [clang-format] Refactor #include insertion/deletion functionality into a class.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 2 02:44:15 PDT 2018


ilya-biryukov added a comment.

> This is really a corner cases that users might not need to know about. But an example is:
>  Code: "#include <a>" (without \n at the end). After inserting <x>, #include <a>\n#include <x>\n (this is good). However, if you insert another <y>, the code would become "#include <a>\n#include <x>\n\n#include <y>\n" (note the double newline!).

Even though that's rare in practice, it seems like an actual bug.
How hard would be it be to fix it?


Repository:
  rC Clang

https://reviews.llvm.org/D46180





More information about the cfe-commits mailing list