[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 1 23:38:34 PDT 2018


sammccall added a comment.

In https://reviews.llvm.org/D42966#1083954, @mikhail.ramalho wrote:

> Hi,
>
> > After thinking about this a bit, and use cases like rename and
> >  find-declaration that could be USR based, I think including some location
> >  information is the right way to go, which I think is the current behavior.
>
> What do you man by location information? Only the filename or filename +
>  offset (current behaviour)?


Filename + offset for things like function parameters, where we have to identify the particular function declaration they're part of.
For static functions themselveds, just the filename. I think this is current behavior in both cases.


Repository:
  rC Clang

https://reviews.llvm.org/D42966





More information about the cfe-commits mailing list