[PATCH] D46218: PR37275 packed attribute should not apply to base classes

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 28 22:00:16 PDT 2018

rsmith added a comment.

In https://reviews.llvm.org/D46218#1081933, @rjmccall wrote:

> Have you checked whether we do the right thing with `#pragma pack` on MSVC?

Great question, I hadn't. Both MSVC and GCC treat `#pragma pack` as applying to base classes, which is what we do with/without this patch. I'll add some tests to cover that.

  rC Clang


More information about the cfe-commits mailing list