[PATCH] D42966: Fix USR generation in the presence of #line directives or linemarkes

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

Re: locations in parameter USRs:

OK, so reading through the code, it looks like locations are included in USRs:

- for macros (except from system headers)
- for decls that aren't externally visible (static etc, function parameters, locals)
- an objective-c class extension case I don't really understand

After thinking about this a bit, and use cases like rename and find-declaration that could be USR based, I think including some location information is the right way to go, which I think is the current behavior.

(I think for the patch itself we're waiting on details about the case that doesn't currently work?)


Repository:
  rC Clang

https://reviews.llvm.org/D42966