[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 26 10:59:18 PDT 2018


vsapsai accepted this revision.
vsapsai added inline comments.
This revision is now accepted and ready to land.


================
Comment at: Sema/SemaDecl.cpp:4651-4653
+
+      DeclContext *OwnerScope = Owner->getRedeclContext();
+
----------------
I think the code style favours avoiding excessive vertical whitespace and I don't feel like this statement is semantically far enough from the surrounding code to be separated from it. I haven't found a specific [LLVM Coding Standards](https://llvm.org/docs/CodingStandards.html) rule, so in this case it is my personal opinion and actual formatting decision is up to you.

Other than that I have no other comments.


https://reviews.llvm.org/D45884





More information about the cfe-commits mailing list