[PATCH] D46052: GNUstep Objective-C ABI version 2

David Chisnall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 26 01:27:03 PDT 2018


theraven updated this revision to Diff 144070.
theraven added a comment.



- Fixed non-use of `isOptional` (in all three places where it should have been used)
- Reject -fobjc-runtime=gnustep-2.x in the driver for non-ELF targets
- Fix a bug where the wrong variable was assigned in protocol generation, which triggered an assertion failure in one of the runtime's tests.
- Rename protocol reference variables to prevent accidental conflicts with protocol references (this was already done for other indirection variables, but I'd missed protocols)


Repository:
  rC Clang

https://reviews.llvm.org/D46052

Files:
  include/clang/AST/Expr.h
  include/clang/Basic/DiagnosticDriverKinds.td
  lib/CodeGen/CGObjCGNU.cpp
  lib/Driver/ToolChains/Clang.cpp
  lib/Frontend/InitPreprocessor.cpp
  test/CodeGenObjC/constant-strings.m
  test/CodeGenObjC/forward-declare-protocol-gnu.m
  test/CodeGenObjC/gnu-empty-protocol-v3.m
  test/CodeGenObjC/gnu-init.m
  test/CodeGenObjC/gnustep2-category.m
  test/CodeGenObjC/gnustep2-class.m
  test/CodeGenObjC/gnustep2-ivar-offset.m
  test/CodeGenObjC/gnustep2-proto.m
  test/CodeGenObjC/ivar-type-encoding.m
  test/Preprocessor/init.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46052.144070.patch
Type: text/x-patch
Size: 116552 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180426/d7d20d7f/attachment-0001.bin>


More information about the cfe-commits mailing list