[PATCH] D46052: GNUstep Objective-C ABI version 2

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 25 13:34:32 PDT 2018


rjmccall added a comment.

Are you asking for a code review or a design review of the ABI?  The second would be much easier to do from a design document.



================
Comment at: lib/CodeGen/CGObjCGNU.cpp:502
+    for (const auto *I : Methods)
+      if (I->getImplementationControl() == ObjCMethodDecl::Optional)
+        OptionalMethods.push_back(I);
----------------
There's an `isOptional()` method now.


Repository:
  rC Clang

https://reviews.llvm.org/D46052





More information about the cfe-commits mailing list