[PATCH] D46002: [clangd] Parse all comments in Sema and completion.

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

Code looks good/simple, just a couple of design questions



================
Comment at: clangd/ClangdUnit.cpp:362
     CI->getFrontendOpts().DisableFree = false;
+    CI->getLangOpts()->CommentOpts.ParseAllComments = true;
   }
----------------
Any idea about whether this will affect performance significantly?
Less for this patch, and more for whether this should be an option in the future that we might e.g. only do during indexing.


================
Comment at: clangd/CodeComplete.cpp:707
   CI->getFrontendOpts().DisableFree = false;
+  CI->getLangOpts()->CommentOpts.ParseAllComments = true;
 
----------------
Are we sure we want to do this in code complete? I would have thought the more natural approach would be to implement resolve in terms of lookup in the index, and only provide it there.
The lack of good support for resolve in YCM LSP shouldn't be a problem as YCM doesn't actually use doc comments (I think?).


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D46002